Skip to content

PcSaftParameters.from_records can not be used without binary parameters #28

New issue
New issue
Closed
#35
Closed
PcSaftParameters.from_records can not be used without binary parameters#28
#35
Assignees
g-bauer
Labels
corerelated to features in feos-core

Description

@prehner
prehner
opened on Jul 7, 2022
c1 = PureRecord(Identifier(), 1.0, PcSaftRecord(1, 3.0, 150.0))
c2 = PureRecord(Identifier(), 1.0, PcSaftRecord(1, 3.0, 150.0))
func = HelmholtzEnergyFunctional.pcsaft(PcSaftParameters.from_records([c1, c2]))

can not be run due to a missing argument. Passing an empty list results in an unwrap error.

Activity

  1. prehner
    added
    pcsaftRelated to the PC-SAFT model
    on Jul 7, 2022

  2. g-bauer commented on Jul 11, 2022

    @g-bauer
    g-bauer
    on Jul 11, 2022
    Contributor

    Replace unwrap with panic with informative error message here

  3. g-bauer
    self-assigned this
    on Jul 11, 2022
  4. prehner
    added
    corerelated to features in feos-core
    and removed
    pcsaftRelated to the PC-SAFT model
    on Jul 11, 2022
  5. prehner
    closed this as completedin #35on Aug 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

corerelated to features in feos-core

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions