Skip to content

Transparency of ideal gas model selection #109

Closed

Description

@prehner

When using PC-SAFT it is somewhat unclear which ideal gas model is used (see, e.g., #68). Should the selection be more explicit? Some thoughts:

  1. The default ideal gas model is nice to have because it leads to correct pressures and derivatives of pressures. However, calculating caloric properties with the default model should be discouraged. At the same time, residual caloric properties are fine.
  2. Caloric properties could be hidden behind a trait similar to mass specific properties. That would not solve the problem for PC-SAFT, though, which clearly should implement that trait.
  3. For PC-SAFT specifically there should probably be either one single method, or an explicit choice.

Then there is also the issue with models implemented in Python:

Activity

  1. added
    pcsaftRelated to the PC-SAFT model
    corerelated to features in feos-core
    on Jan 12, 2023
  2. added this to the v0.5.0 milestone on Jan 27, 2023
  3. linked a pull request that will close this issueRevised handling of ideal gas contribution #158on Jul 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    corerelated to features in feos-corepcsaftRelated to the PC-SAFT model

    Type

    No type

    Projects

    No projects

      Milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions