Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: felixge/httpsnoop
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: master
Choose a base ref
...
head repository: felixge/httpsnoop
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: pda-unwrap
Choose a head ref
Checking mergeability… Don’t worry, you can still create the pull request.
  • 6 commits
  • 7 files changed
  • 2 contributors

Commits on Nov 28, 2018

  1. Wrapped ResponseWriters implement Unwrapper interface

    @pda
    pda committed Nov 28, 2018
    Configuration menu
    Copy the full SHA
    b6f3fcd View commit details
    Browse the repository at this point in the history

  2. Test Unwrap() implementations

    @pda
    pda committed Nov 28, 2018
    Configuration menu
    Copy the full SHA
    edcbcad View commit details
    Browse the repository at this point in the history

  3. func Unwrap: recursive helper function

    @pda
    pda committed Nov 28, 2018
    Configuration menu
    Copy the full SHA
    415843b View commit details
    Browse the repository at this point in the history

  4. README mentions httpsnoop.Unwrap(w)

    @pda
    pda committed Nov 28, 2018
    Configuration menu
    Copy the full SHA
    c3be43e View commit details
    Browse the repository at this point in the history

Commits on Dec 12, 2018

  1. Revert "Wrapped ResponseWriters implement Unwrapper interface" 

    This reverts commit b6f3fcd.
    @felixge
    felixge committed Dec 12, 2018
    Configuration menu
    Copy the full SHA
    44a4887 View commit details
    Browse the repository at this point in the history

  2. simplify previous Unwrap implementation 

    By declaring it directly on `*rw`, we don't have a needed for the named
types anymore, making things a lot simpler.
    @felixge
    felixge committed Dec 12, 2018
    Configuration menu
    Copy the full SHA
    eafe786 View commit details
    Browse the repository at this point in the history
Loading