Adding some suggestions in the readme#16
Open
pedbarros wants to merge 1 commit intofelipe-augusto:masterfrom
Open
Adding some suggestions in the readme#16pedbarros wants to merge 1 commit intofelipe-augusto:masterfrom
pedbarros wants to merge 1 commit intofelipe-augusto:masterfrom
Conversation
lucalves
approved these changes
Oct 5, 2020
ivanmpe
approved these changes
Dec 13, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Por favor, quando for submeter alguma PR nova fazer a distinção entre dois tipos de PR (Fix e Sugestão), e colocar qual é o tipo no nome da PR. Não mesclar os dois tipos de commits numa mesma PR.
[FIX] Encontrou algum erro de gramática, acentuação errada, tradução mal feita, imagens ou links quebrados, mande uma deste tipo.
[SUGESTAO] Encontrou algum exemplo ruim, quer melhorar os parágrafos com mais exemplos, sugerir alguma prática de código limpo que está faltando ou qualquer mudança que também precise ser feita no repositório original.
Essa distinção é importante, pois cada PR do tipo sugestão precisa ser aberta também no repositório original para manter um nível de consistência entre os dois.