Conversation
Signed-off-by: Mihai Budiu <mbudiu@feldera.com>
These tests guard against regression for the fix in commit 0e3bc33 ("[SQLLIB] Fix bug in DECIMAL division"). Signed-off-by: Ben Pfaff <blp@feldera.com>
This fixes two classes of bugs in fixed-point addition. First, in the existing special case for handling addition of fixed-points with different scales where shifting the addend with the smaller scale left yielded a value that did not fit in i128, the special case was wrong when the result's scale differed from that of the added with the larger scale. This fixes the problem and adds a test. Second, the code did not handle the special case where the sum of the addends does not fit in i128 in the larger of the scales of the addends but it would fit with the scale of the result. This also fixes that bug and adds a test. Signed-off-by: Ben Pfaff <blp@feldera.com>
blp
added
bug
gz
approved these changes
Mar 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds unit tests.
I submitted this separately from #5947 because I can't push to @mihaibudiu's repository.