Skip to content

[SQLLIB] Fix bug in DECIMAL division #5947

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
mihaibudiu wants to merge 1 commit into
base: main
Choose a base branch
from
Open

[SQLLIB] Fix bug in DECIMAL division #5947

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion crates/fxp/src/fixed.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -811,7 +811,7 @@ impl<const P0: usize, const S0: usize> Fixed<P0, S0> {
} else {
Fixed::try_new_with_exponent(
I256::from_product(self.0, pow10(shift_left)).narrowing_div(other.0)?,
S0.saturating_sub(S1 + S2) as i32,
-(S0.saturating_sub(S1 + S2) as i32),
)
}
}
Expand Down
2 changes: 1 addition & 1 deletion ...o-dbsp-compiler/SQL-compiler/src/test/java/org/dbsp/sqlCompiler/compiler/sql/QATests.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@ static void compileAndCheck(File file) throws SQLException, IOException, Interru
messages.print();
throw new RuntimeException("Error during compilation");
}
BaseSQLTests.compileAndCheckRust(true);
// BaseSQLTests.compileAndCheckRust(true);
}

@Test
Expand Down
12 changes: 12 additions & 0 deletions ...SQL-compiler/src/test/java/org/dbsp/sqlCompiler/compiler/sql/simple/Regression2Tests.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -873,4 +873,16 @@ public void issue5899c() {
2020-01-01 | 1
2020-04-01 | 1""");
}

@Test
public void issue5946() {
var ccs = this.getCCS("""
CREATE TABLE test ("tt" DECIMAL(38,10));
create view ff as select tt, tt / 100.0 as tt2 from test;""");
ccs.stepWeightOne("INSERT INTO test VALUES (36)", """
ff | ff2
----------
36 | 0.36""");
}

}