[SQLLIB] Fix bug in DECIMAL division#5947
Open
mihaibudiu wants to merge 1 commit intofeldera:mainfrom
Open
Conversation
Signed-off-by: Mihai Budiu <mbudiu@feldera.com>
Contributor
Author
|
@blp maybe you will want to add a couple of tests to the fxp library to cover this if this is indeed the problem |
Contributor
|
you could probably just fuzz this using arbitrary arithemtic and validate against python decimal or similar |
Member
Fuzzing is a good idea but it's also important, IMO, to have handwritten test cases that cover all the special cases. We missed some. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist