[SQL] Fix incorrect implementation of LEFT JOINs after sharing indexes#5936
Merged
mihaibudiu merged 1 commit intofeldera:mainfrom Mar 27, 2026
Merged
[SQL] Fix incorrect implementation of LEFT JOINs after sharing indexes#5936mihaibudiu merged 1 commit intofeldera:mainfrom
mihaibudiu merged 1 commit intofeldera:mainfrom
Conversation
Contributor
Author
|
The bug was in the rewriting of the join functions when receiving inputs from a different index operator: the join function is actually the composition of the original join function with a function which shifts the indices of the input parameter to accommodate for the wider index output. There was actually a much shorter fix, but it would generate worse code, because we haven't implemented #5507. |
Signed-off-by: Mihai Budiu <mbudiu@feldera.com>
gz
approved these changes
Mar 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #5935
Checklist