Conversation
gz
approved these changes
Mar 26, 2026
blp
approved these changes
Mar 26, 2026
Member
blp
left a comment
blp
left a comment
There was a problem hiding this comment.
It's hard to know the intended semantics because I don't see relevant comments on functions or data. It would be good to add some.
Currently, even if sync fails, we update last_sync, due to which `periodic` in checkpoint status reports a UUID whose sync actually failed. This isn't correct, we should only set it if sync was successful. periodic checkpoints gets retried anyways, so it if fine to ignore failed ones. Signed-off-by: Swanand Mulay <73115739+swanandx@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently, even if sync fails, we update last_sync, due to which
periodicin checkpoint status reports a UUID whose sync actually failed.This isn't correct, we should only set it if sync was successful. periodic checkpoints gets retried anyways, so it if fine to ignore failed ones.
Fix #5924
Describe Manual Test Plan
Tested with local minio with invalid credentials to simulate write failures. Didn't see failed checkpoint uuid getting reported.
Successful checkpoint update
periodicas wellChecklist
Breaking Changes?
Bug fix, shouldn't be breaking change