[SQL] Fix three compiler/runtime bugs from #5899#5909
Merged
mihaibudiu merged 1 commit intofeldera:mainfrom Mar 26, 2026
Merged
[SQL] Fix three compiler/runtime bugs from #5899#5909mihaibudiu merged 1 commit intofeldera:mainfrom
mihaibudiu merged 1 commit intofeldera:mainfrom
Conversation
Contributor
Author
|
@wilmaontherun you can check that the unit tests solve the problems. |
Collaborator
wilmaontherun
left a comment
wilmaontherun
left a comment
There was a problem hiding this comment.
looks good! If I encore more tests, I will share
wilmaontherun
approved these changes
Mar 24, 2026
Collaborator
wilmaontherun
left a comment
wilmaontherun
left a comment
There was a problem hiding this comment.
looks good! If I encore more tests, I will share
Signed-off-by: Mihai Budiu <mbudiu@feldera.com>
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #5899
There are actually 3 different bugs in the same issue.
OVERLAY has functionality unit tests, but didn't for nullability.
Checklist