Skip to content

Issue 5905: quiet build warnings during non-present git folder #5906

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
gz merged 1 commit into from
Mar 24, 2026
Merged

Issue 5905: quiet build warnings during non-present git folder #5906

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion crates/adapters/build.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,10 @@ use vergen_gitcl::*;

fn main() -> Result<(), Box<dyn std::error::Error>> {
let gitcl = GitclBuilder::default().sha(false).dirty(false).build()?;
Emitter::default().add_instructions(&gitcl)?.emit()?;
Emitter::default()
.add_instructions(&gitcl)?
.quiet()
.emit()?;

println!("cargo:rerun-if-env-changed=FELDERA_RUNTIME_OVERRIDE");
Ok(())
Expand Down
1 change: 1 addition & 0 deletions crates/pipeline-manager/build.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -120,6 +120,7 @@ fn main() -> Result<(), Box<dyn std::error::Error>> {
.add_instructions(&gitcl)?
.add_instructions(&rustc)?
.add_instructions(&si)?
.quiet()
Copy link
Copy Markdown
Contributor

@mihaibudiu mihaibudiu Mar 24, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

wouldn't some warnings be useful?

Copy link
Copy Markdown
Contributor Author

@gz gz Mar 24, 2026 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it only quiets the warnings that corresponds to not finding the relevant information here (gitcl, rustc, system info etc.) not warnings in the code

.emit()?;
Ok(())
}
Loading