Issue 5905: quiet build warnings during non-present git folder#5906
Merged
Conversation
In docker builds we often execute build scripts without a proper .git folder present. In this case the vergen Emitter emits a warning through cargo. This is confusing for users. This make sure the warning disappears. Our code already handles the cases where these env variables are not set. Signed-off-by: Gerd Zellweger <mail@gerdzellweger.com>
Contributor
Author
|
Fixes #5905 |
mihaibudiu
approved these changes
Mar 24, 2026
| .add_instructions(&gitcl)? | ||
| .add_instructions(&rustc)? | ||
| .add_instructions(&si)? | ||
| .quiet() |
Contributor
There was a problem hiding this comment.
wouldn't some warnings be useful?
Contributor
Author
There was a problem hiding this comment.
it only quiets the warnings that corresponds to not finding the relevant information here (gitcl, rustc, system info etc.) not warnings in the code
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe Manual Test Plan
I ran the build with and without the diff and made sure the warnings disappear.