Skip to content

[SQL] Fix conversion of DECIMAL(38, x) to INTEGER #5891

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mihaibudiu merged 1 commit into from
Mar 21, 2026
+2 −1
Merged

[SQL] Fix conversion of DECIMAL(38, x) to INTEGER #5891

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion ...er/SQL-compiler/src/main/java/org/dbsp/sqlCompiler/ir/type/primitive/DBSPTypeInteger.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -92,7 +92,7 @@ else if (precision < 10)
return INT32;
else if (precision < 19)
return INT64;
else if (precision < 38)
else if (precision <= 38)
return INT128;
return null;
}
Expand Down
1 change: 1 addition & 0 deletions ...o-dbsp-compiler/SQL-compiler/src/test/java/org/dbsp/sqlCompiler/compiler/sql/QATests.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,6 +28,7 @@ public void qaTests() throws IOException, SQLException, InterruptedException {
for (File c : BaseSQLTests.getQATests()) {
// This program cannot be compiled because it contains a udf
if (c.toString().matches(".*swiss.*-q1.*")) continue;
// if (!c.toString().contains("x.sql")) continue;
System.out.println("Compiling " + c);
try {
compileAndCheck(c);
Expand Down
Loading