[SQL] Add support for FORMAT_TIMESTAMP and FORMAT_TIME#5889
Merged
mihaibudiu merged 1 commit intomainfrom Mar 23, 2026
Merged
Conversation
Signed-off-by: Mihai Budiu <mbudiu@feldera.com>
Contributor
Author
mythical-fred
approved these changes
Mar 21, 2026
mythical-fred
left a comment
mythical-fred
left a comment
There was a problem hiding this comment.
LGTM. Good test coverage. One nit: the import of DBSPConcreteAsofJoinOperator added to ExpressionCompiler.java (line 44) is unused — please remove it.
anandbraman
approved these changes
Mar 23, 2026
Contributor
anandbraman
left a comment
anandbraman
left a comment
There was a problem hiding this comment.
LGTM! Thanks for adding these
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #5863
We had
FORMAT_DATEbut notFORMAT_TIMESTAMPofFORMAT_TIME, and they are not so easy to build from other functions.Describe Manual Test Plan
Compared with Rust playground results
Checklist