Skip to content

ci: build fda for Windows amd64 #5849

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jyotshnayaparla-00 merged 2 commits into from
Mar 18, 2026
Merged

ci: build fda for Windows amd64 #5849

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
70b3c0f
ci: build fda for Windows amd64
jyotshnayaparla-00 Mar 17, 2026
1540d0e
Keep macOS as unsupported in install-fda until binary is available
jyotshnayaparla-00 Mar 17, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
44 changes: 44 additions & 0 deletions .github/workflows/build-rust.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -136,3 +136,47 @@ jobs:
name: pipeline-manager-${{ matrix.target }}
path: build-release-artifacts/pipeline-manager
retention-days: 7

build-fda-native:
Copy link
Copy Markdown

@mythical-fred mythical-fred Mar 17, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR contains two extra commits that do not belong here:

Please rebase onto current main and squash/drop these before merging. The only commit that should remain is ci: build fda for Windows amd64.

name: Build fda (Windows)

# Builds fda for Windows using GitHub-hosted larger runners.
# macOS arm64 will be added once self-hosted macOS runners are available.
# Windows arm64 is skipped for now — the runner lacks Rust and MSVC.
strategy:
matrix:
include:
- runner: windows-latest-amd64
target: x86_64-pc-windows-msvc
runs-on: ${{ matrix.runner }}

# sccache is not available on Windows GitHub-hosted runners
env:
RUSTC_WRAPPER: ""

steps:
- name: Checkout repository
uses: actions/checkout@v6

- name: Add Rust target
run: rustup target add ${{ matrix.target }}

- name: Cache Cargo registry and index
uses: actions/cache@v5
with:
path: |
~/.cargo/registry
~/.cargo/git
key: cargo-registry-${{ runner.os }}-${{ matrix.target }}-${{ hashFiles('**/Cargo.lock') }}
restore-keys: |
cargo-registry-${{ runner.os }}-${{ matrix.target }}-

- name: Build fda
run: cargo build --release --locked -p fda --target=${{ matrix.target }}

- name: Upload fda
uses: actions/upload-artifact@v7
with:
name: fda-${{ matrix.target }}
path: target/${{ matrix.target }}/release/fda.exe
retention-days: 7
1 change: 1 addition & 0 deletions .github/workflows/ci-release.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -111,6 +111,7 @@ jobs:
pipeline-manager-x86_64-unknown-linux-gnu.zip
fda-x86_64-unknown-linux-gnu.zip
fda-aarch64-unknown-linux-gnu.zip
fda-x86_64-pc-windows-msvc.zip
sql2dbsp-jar-with-dependencies-v${{ env.CURRENT_VERSION }}.jar
feldera-sbom-source.spdx.json
feldera-sbom-image.spdx.json
Expand Down
1 change: 1 addition & 0 deletions .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,6 +53,7 @@ jobs:
required-artifacts: |
fda-x86_64-unknown-linux-gnu
fda-aarch64-unknown-linux-gnu
fda-x86_64-pc-windows-msvc
pipeline-manager-x86_64-unknown-linux-gnu
pipeline-manager-aarch64-unknown-linux-gnu
feldera-test-binaries-x86_64-unknown-linux-gnu
Expand Down
33 changes: 16 additions & 17 deletions docs.feldera.com/static/install-fda
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,31 +47,30 @@ detect_platform() {
ARCH="$(uname -m)"

case "$OS" in
Linux) ;;
Linux)
case "$ARCH" in
x86_64 | amd64)
TARGET="x86_64-unknown-linux-gnu"
;;
aarch64 | arm64)
TARGET="aarch64-unknown-linux-gnu"
;;
*)
err "unsupported Linux architecture: $ARCH. Supported: x86_64, aarch64"
;;
esac
info "Detected platform: Linux $ARCH"
;;
Darwin)
err "MacOS is not currently supported. Install fda with: cargo install fda"
err "macOS is not currently supported. Install fda with: cargo install fda"
;;
MINGW* | MSYS* | CYGWIN*)
err "Windows is not currently supported. Install fda with: cargo install fda"
err "Windows is not currently supported by this installer. Download fda from https://github.com/feldera/feldera/releases or install with: cargo install fda"
;;
*)
err "unsupported operating system: $OS"
;;
esac

case "$ARCH" in
x86_64 | amd64)
TARGET="x86_64-unknown-linux-gnu"
;;
aarch64 | arm64)
TARGET="aarch64-unknown-linux-gnu"
;;
*)
err "unsupported architecture: $ARCH. Supported: x86_64, aarch64"
;;
esac

info "Detected platform: Linux $ARCH"
}

resolve_version() {
Expand Down
Loading