Skip to content

ci: fix pre-commit job still passing when pre-commit fails #5790

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jyotshnayaparla-00 merged 1 commit into from
Mar 11, 2026
Merged

ci: fix pre-commit job still passing when pre-commit fails #5790

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions .github/workflows/ci-pre-mergequeue.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -77,12 +77,11 @@ jobs:
pre-commit run --show-diff-on-failure --color=always --all-files
shell: bash
if: ${{ vars.CI_DRY_RUN != 'true' }}
continue-on-error: ${{ github.event.pull_request.head.repo.full_name == github.repository }}
- name: Print sccache stats
run: sccache --show-stats
- uses: stefanzweifel/git-auto-commit-action@b863ae1933cb653a53c021fe36dbb774e1fb9403
# Only attempt auto-fix commits for branches in this repo (forks can't be pushed to)
if: ${{ github.event.pull_request.head.repo.full_name == github.repository }}
if: ${{ always() && github.event.pull_request.head.repo.full_name == github.repository }}
with:
commit_message: "[ci] apply automatic fixes"
commit_user_name: feldera-bot
Expand Down
Loading