Skip to content

[Python SDK] use iter_lines to read HTTP response. #1798

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
abhizer merged 1 commit into from
May 28, 2024
Merged

[Python SDK] use iter_lines to read HTTP response. #1798

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 4 additions & 11 deletions python/feldera/rest/client.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -485,17 +485,10 @@ def listen_to_pipeline(

end = time.time() + timeout if timeout else None

old_chunk = b""

for chunk in resp.iter_content(chunk_size=None):
# Using the default chunk size below makes `iter_lines` extremely
# inefficient when dealing with long lines.
for chunk in resp.iter_lines(chunk_size=50000000):
if end and time.time() > end:
break
if chunk:
try:
chunk = old_chunk + chunk
valid_json = json.loads(chunk)
old_chunk = b""
yield valid_json
except json.decoder.JSONDecodeError:
old_chunk += chunk
continue
yield json.loads(chunk)