[Python SDK] use iter_lines to read HTTP response.#1798
Merged
abhizer merged 1 commit intoforeach_chunkfrom May 28, 2024
Merged
[Python SDK] use iter_lines to read HTTP response.#1798abhizer merged 1 commit intoforeach_chunkfrom
abhizer merged 1 commit intoforeach_chunkfrom
Conversation
mihaibudiu
approved these changes
May 28, 2024
Contributor
|
I wanted to switch to |
Use `iter_lines` to read HTTP response line-by-line. This way we don't need to worry about incomplete chunks. The previous implementation also ran out of memory on large outputs. I did not figure out what was going on exactly, but it used up 20GB of RAM while parsing a few thousand records. This implementation does not seem to have that problem. Signed-off-by: Leonid Ryzhyk <leonid@feldera.com>
Contributor
Author
|
What kind of self-respecting software uses |
abhizer
approved these changes
May 28, 2024
gz
pushed a commit
that referenced
this pull request
May 28, 2024
Use `iter_lines` to read HTTP response line-by-line. This way we don't need to worry about incomplete chunks. The previous implementation also ran out of memory on large outputs. I did not figure out what was going on exactly, but it used up 20GB of RAM while parsing a few thousand records. This implementation does not seem to have that problem. Signed-off-by: Leonid Ryzhyk <leonid@feldera.com> Co-authored-by: Leonid Ryzhyk <leonid@feldera.com>
gz
pushed a commit
that referenced
this pull request
May 28, 2024
Use `iter_lines` to read HTTP response line-by-line. This way we don't need to worry about incomplete chunks. The previous implementation also ran out of memory on large outputs. I did not figure out what was going on exactly, but it used up 20GB of RAM while parsing a few thousand records. This implementation does not seem to have that problem. Signed-off-by: Leonid Ryzhyk <leonid@feldera.com> Co-authored-by: Leonid Ryzhyk <leonid@feldera.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Use
iter_linesto read HTTP response line-by-line. This way we don't need to worry about incomplete chunks. The previous implementation also ran out of memory on large outputs. I did not figure out what was going on exactly, but it used up 20GB of RAM while parsing a few thousand records. This implementation does not seem to have that problem.Is this a user-visible change (yes/no): ___