It would be nice if we don't explicitly have to wrap things in a Runtime::init_bla closure. e.g., we can take some inspiration on how tokio does it with a macro annotation for main and tests (and an explicit API that hopefully doesn't have to be used much).

I don't think it's much of a wrapper. The full needed change for one of the tutorial examples is this, for example:

diff --git a/crates/dbsp/examples/tutorial/tutorial2.rs b/crates/dbsp/examples/tutorial/tutorial2.rs
index 3810ecb0..c9c7c8e4 100644
--- a/crates/dbsp/examples/tutorial/tutorial2.rs
+++ b/crates/dbsp/examples/tutorial/tutorial2.rs
@@ -2,7 +2,7 @@ use anyhow::Result;
 use chrono::NaiveDate;
 use csv::Reader;
 use dbsp::utils::Tup2;
-use dbsp::{RootCircuit, ZSet, ZSetHandle};
+use dbsp::{RootCircuit, Runtime, ZSet, ZSetHandle};
 use rkyv::{Archive, Serialize};
 use size_of::SizeOf;
 
@@ -39,7 +39,7 @@ fn build_circuit(circuit: &mut RootCircuit) -> Result<ZSetHandle<Record>> {
 
 fn main() -> Result<()> {
     // Build circuit.
-    let (circuit, input_handle) = RootCircuit::build(build_circuit)?;
+    let (mut circuit, input_handle) = Runtime::init_circuit(1, build_circuit)?;
 
     // Feed data into circuit.
     let path = format!(

Get rid of circuits without a runtime #2117

Description

Metadata

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

Issue actions