Avoid reading char by char by using a 4k buffer

stain · stain · commit 391d4e34c5f7 · 2013-08-15T03:13:24.000+01:00
This also removes the need for BufferedReader.
diff --git a/core/src/main/java/com/github/jsonldjava/utils/JSONUtils.java b/core/src/main/java/com/github/jsonldjava/utils/JSONUtils.java
@@ -129,9 +129,10 @@ public static Object fromString(String jsonString) throws JsonParseException,
 
     public static Object fromReader(Reader r) throws IOException {
         final StringBuffer sb = new StringBuffer();
+        char[] buffer = new char[4096];
         int b;
-        while ((b = r.read()) != -1) {
-            sb.append((char) b);
+        while ((b = r.read(buffer)) != -1) {
+            sb.append(buffer, 0, b);
         }
         return fromString(sb.toString());
     }
@@ -159,7 +160,7 @@ public static Object fromInputStream(InputStream content) throws IOException {
     }
 
     public static Object fromInputStream(InputStream content, String enc) throws IOException {
-        return fromReader(new BufferedReader(new InputStreamReader(content, enc)));
+        return fromReader(new InputStreamReader(content, enc));
     }
 
     public static String toPrettyString(Object obj) {

Original file line number	Diff line number	Diff line change
`@@ -129,9 +129,10 @@ public static Object fromString(String jsonString) throws JsonParseException,`
`129`	`129`
`130`	`130`	`public static Object fromReader(Reader r) throws IOException {`
`131`	`131`	`final StringBuffer sb = new StringBuffer();`
	`132`	`+ char[] buffer = new char[4096];`
`132`	`133`	`int b;`
`133`		`- while ((b = r.read()) != -1) {`
`134`		`- sb.append((char) b);`
	`134`	`+ while ((b = r.read(buffer)) != -1) {`
	`135`	`+ sb.append(buffer, 0, b);`
`135`	`136`	`}`
`136`	`137`	`return fromString(sb.toString());`
`137`	`138`	`}`
`@@ -159,7 +160,7 @@ public static Object fromInputStream(InputStream content) throws IOException {`
`159`	`160`	`}`
`160`	`161`
`161`	`162`	`public static Object fromInputStream(InputStream content, String enc) throws IOException {`
`162`		`- return fromReader(new BufferedReader(new InputStreamReader(content, enc)));`
	`163`	`+ return fromReader(new InputStreamReader(content, enc));`
`163`	`164`	`}`
`164`	`165`
`165`	`166`	`public static String toPrettyString(Object obj) {`