Skip to content

Conversation

@Ester-Ramos
Copy link
Collaborator

Tell me if you think anything is missing an image
This closes #4

@alesssia
Copy link
Collaborator

Hi @estramcar,
have a look at the first half of the tutorial, where would you include these screenshots? Once the pull request is merge I will add them. Do you think any extra screenshots will be useful to make my text more clear (see also comment to my pull request 😁 )

@feiphoon
Copy link
Owner

Hallo hallo! I haven't looked at all of these yet, but FYI in Github you can change the merge destination of the pull request at any time :)

@Ester-Ramos
Copy link
Collaborator Author

Ester-Ramos commented Feb 20, 2019

I'm going to change the pull request to @alesssia 's branch so you can have the images for the tutorial
I can't change the PR because @alesssia forked the repo and the branch is there. How do we do it then?

@Ester-Ramos
Copy link
Collaborator Author

I can also merge it to master if you are all okay with it and @alesssia can do a pull

@alesssia
Copy link
Collaborator

Hello @estramcar, I close #6 and pushed directly on @feiphoon's repo, as described in #6 and #8. You should be able to work directly on the gh-pages branch, that is where the "website" should live

@Ester-Ramos Ester-Ramos changed the base branch from master to gh-pages February 20, 2019 20:07
@Ester-Ramos
Copy link
Collaborator Author

I´m going to merge with your branch @alesssia. That way I can start adding the images in the tutorial

@Ester-Ramos Ester-Ramos merged commit f61d1f9 into gh-pages Feb 20, 2019
@alesssia
Copy link
Collaborator

Perfect! Feel free to work on the text as well and fix everything that does not look ok!
If you want to add images on task 5 as well, just create a md file and then I will include the text once you push.

@Ester-Ramos Ester-Ramos deleted the tutorial-screenshots branch February 21, 2019 10:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants