-
Notifications
You must be signed in to change notification settings - Fork 1
Closed
Description
Hi @feiphoon, and hi @estramcar,
as promised, no more forking (neither in this repo, nor in the tutorial). Now the website is living in the correct place (I hope 😊 ), that is the gh-pages branch, and should be live once @feiphoon enables their publishing via Setting (as explained here: https://help.github.com/articles/configuring-a-publishing-source-for-github-pages/) I have no permission 😅
@estramcar you should be able to work on this branch and then open a PR, as per #5
I am reporting here the tasks:
- Setting up (points 2-4)
- Working all on the same branch (point 5)
- Creating and dealing with issue (points 6 and 7)
- Working on your own branch (point 8-11)
- Merging all together (point 11-20)
So far I worked up to task 4, edited as suggested and tomorrow/Friday I will work on task 5.
Here are the main points to check
In general:
- Spelling and grammar
- Is the text clear?
index.md
- Does anyone wants to suggest something to stress the message "be kind"? Or will this be in the talk? Fei: I'll take care of this one, I want this vibe to be prominent across the entire workshop as it's very important. I'll have this on a slide during the practical, and we can add this later elsewhere at the end of this PR. *Alessia: included from your slides"
setting-up.md
- Can someone confirm that the only way to accept is via email? I am usually the one that invites people 😊 Fei: I've forgotten, can you ask Chiin as I see she hasn't accepted my invite yet? Or make a test repo and invite me :) Alessia: asked, if she does not answer or has already accepted I will invite you to my test repo
issues.md
- Are those appropriate questions? 😱
own-branch.md
- After you fork you are led directly on your own page, right? Since I am owning the repo I am using for testing I cannot really test ot 😊 Fei: Question! Was forking the only way you could work on this repo? I think you have direct push access. If this is correct, can we exclude forking from the exercise, but mention it (it IS important!) in the wrap-up? Alessia: no more forking
Metadata
Metadata
Assignees
Labels
No labels