Repository navigation
Item Editor inline creation triggering not compatible with Django 1.5 #390
Description
In fact since the change in django/django@b719cbb90#L0L119 , https://github.com/feincms/feincms/blob/master/feincms/static/feincms/item_editor.js#L187 no longer correctly detects successful inline creation, so creates multiples. The extra (invisible) inlines can also cause hidden ValidationErrors. I'm looking into a fix for this now, but would be surprised if this hasn't already been reported elsewhere?
Activity
Fix feincms#390: No longer depend on return value of add-row handler.
matthiask commentedon Feb 25, 2013
Thanks! Does this fix work with Django 1.4 too, or only with the upcoming 1.5?
DrMeers commentedon Feb 25, 2013
Yes, it should be the same for both. I can't see why I didn't write it this way in the first place actually (which concerns me slightly...). The only reason I could imagine it failing this way is if the handler gets triggered asynchronously, but I'm pretty sure they don't work that way.
Merge branch 'master' into next
Merge branch 'v1.6.4'