Skip to content

Commit fe916df

Browse files
committed
Class-based preview view actually works now
1 parent e890850 commit fe916df

2 files changed

Lines changed: 4 additions & 4 deletions

File tree

‎feincms/contrib/preview/urls.py‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,5 +3,5 @@
33
from feincms.contrib.preview.views import PreviewHandler
44

55
urlpatterns = patterns('',
6-
url(r'^(.*)/_preview/(\d+)/$', PreviewHandler(), name='feincms_preview'),
6+
url(r'^(.*)/_preview/(\d+)/$', PreviewHandler.as_view(), name='feincms_preview'),
77
)

‎feincms/contrib/preview/views.py‎

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -19,17 +19,17 @@ def handler(self, request, path, page_id):
1919
if not request.user.is_staff:
2020
raise Http404
2121

22-
page = get_object_or_404(Page, pk=page_id)
22+
self.page = get_object_or_404(Page, pk=page_id)
2323

2424
# Throw out request processor which will cause the page to-be-previewed
2525
# to be seen as inactive (which is the case, of course)
26-
page.request_processors = [rp for rp in Page.request_processors if rp not in (
26+
self.page.request_processors = [rp for rp in Page.request_processors if rp not in (
2727
processors.require_path_active_request_processor,)]
2828

2929
# Remove _preview/42/ from URL, the rest of the handler code should not
3030
# know that anything about previewing. Handler.prepare will still raise
3131
# a 404 if the extra_path isn't consumed by any content type
32-
request.path = page.get_absolute_url()
32+
request.path = self.page.get_absolute_url()
3333

3434
response = self.prepare()
3535
if response:

0 commit comments

Comments
 (0)