Skip to content

Commit 7ebc02d

Browse files
zhurczhurc
committed
增加代码质量检查工具(逐步完善规则)
1 parent b284f58 commit 7ebc02d

File tree

199 files changed

+65285
-60970
lines changed

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

199 files changed

+65285
-60970
lines changed

‎.eslintignore‎

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,3 @@
1+
# Ignore files
2+
src/classic/libs/*
3+
src/common/style/CartoCSS.js

‎.eslintrc.js‎

Lines changed: 55 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,55 @@
1+
module.exports = {
2+
"env": {
3+
"browser": true,
4+
"node": true,
5+
"commonjs": true,
6+
//启用 ES6 语法
7+
"es6": true
8+
},
9+
"root": true,
10+
"parser": "babel-eslint",
11+
"parserOptions": {
12+
//启用 ES6 语法
13+
"ecmaVersion": 6,
14+
"sourceType": "module"
15+
},
16+
"extends": ["eslint:recommended"],
17+
"rules": {
18+
//8个空格缩进
19+
"indent": ["off", 8, {"SwitchCase": 1}],
20+
//禁止不必要的分号
21+
"no-extra-semi": "warn",
22+
//强制使用一致的换行风格
23+
"linebreak-style": ["warn", "windows"],
24+
//if while function 后面的{必须与if在同一行，java风格。
25+
"brace-style": ["warn", "1tbs", {"allowSingleLine": true}],
26+
//数组和对象键值对最后一个逗号， never参数：不能带末尾的逗号
27+
"comma-dangle": ["error", "never"],
28+
//不强制规定引号的使用
29+
"quotes": "off",
30+
//强制所有控制语句使用一致的括号风格
31+
"curly": "warn",
32+
//允许有console输出
33+
"no-console": "off",
34+
//禁止多次声明同一变量
35+
"no-redeclare": "warn",
36+
//允许出现未使用过的变量
37+
"no-unused-vars": "off",
38+
//不要求在构造函数中有 super() 的调用
39+
"constructor-super": "off",
40+
//允许在嵌套的块中出现function声明
41+
"no-inner-declarations": "off",
42+
//强制数组方法的回调函数中有 return 语句
43+
"array-callback-return": "error",
44+
//禁用未声明的变量，除非它们在 /*global */ 注释中被提到
45+
"no-undef": "error",
46+
//禁止将标识符定义为受限的名字
47+
"no-shadow-restricted-names": "error",
48+
//允许不必要的转义字符
49+
"no-useless-escape": "off",
50+
//禁止 case 语句落空
51+
"no-fallthrough": "warn",
52+
//禁止直接调用eval()
53+
"no-eval": ["error", {"allowIndirect": true}]
54+
},
55+
};

‎build/webpack.config.classic.js‎

Lines changed: 10 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -27,6 +27,14 @@ module.exports = {
2727
},
2828
module: {
2929
rules: [{
30+
test: [/\.js$/],
31+
exclude: /node_modules/,
32+
enforce: 'pre',
33+
loader: 'eslint-loader',
34+
options: {
35+
failOnError: true
36+
}
37+
}, {
3038
test: /\.js/,
3139
loader: 'babel-loader',
3240
query: {
@@ -38,7 +46,8 @@ module.exports = {
3846
}]
3947
},
4048
plugins: [
41-
new webpack.BannerPlugin(banner)
49+
new webpack.BannerPlugin(banner),
50+
new webpack.NoEmitOnErrorsPlugin()
4251
]
4352

4453
};

‎build/webpack.config.leaflet.js‎

Lines changed: 14 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -25,9 +25,9 @@ module.exports = {
2525
externals: {
2626
'leaflet': 'L',
2727
'echarts': 'function(){try{return echarts}catch(e){return {}}}()',
28-
'mapv': "function(){try{return mapv}catch(e){return {}}}()",
28+
'mapv': "function(){try{return mapv}catch(e){return {}}}()",
2929
'elasticsearch': 'function(){try{return elasticsearch}catch(e){return {}}}()',
30-
'@turf/turf': "function(){try{return turf}catch(e){return {}}}()",
30+
'@turf/turf': "function(){try{return turf}catch(e){return {}}}()",
3131
},
3232

3333
module: {
@@ -40,6 +40,14 @@ module.exports = {
4040
limit: 30000
4141
}
4242
}]
43+
}, {
44+
test: [/\.js$/],
45+
exclude: /node_modules/,
46+
enforce: 'pre',
47+
loader: 'eslint-loader',
48+
options: {
49+
failOnError: true
50+
}
4351
}, {
4452
test: [/\.js$/],
4553
exclude: /node_modules[\/\\]proj4|classic/,
@@ -50,12 +58,11 @@ module.exports = {
5058
'transform-class-properties',
5159
]
5260
}
53-
},{
61+
}, {
5462
test: /\.js$/,
55-
enforce:"post",
63+
enforce: "post",
5664
loaders: ['es3ify-loader'],
57-
},
58-
{
65+
}, {
5966
test: /\.css$/,
6067
use: ExtractTextPlugin.extract({
6168
use: {
@@ -68,6 +75,7 @@ module.exports = {
6875
plugins: [
6976
new webpack.BannerPlugin(banner),
7077
new ExtractTextPlugin('/../dist/' + packageName + ".css"),
78+
new webpack.NoEmitOnErrorsPlugin()
7179
]
7280

7381
};

‎build/webpack.config.mapboxgl.js‎

Lines changed: 12 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -23,7 +23,7 @@ module.exports = {
2323
externals: {
2424
'echarts': 'function(){try{return echarts}catch(e){return {}}}()',
2525
'mapbox-gl': 'mapboxgl',
26-
'mapv': "function(){try{return mapv}catch(e){return {}}}()",
26+
'mapv': "function(){try{return mapv}catch(e){return {}}}()",
2727
'elasticsearch': 'function(){try{return elasticsearch}catch(e){return {}}}()'
2828
},
2929

@@ -38,7 +38,15 @@ module.exports = {
3838
limit: 30000
3939
}
4040
}]
41-
},{
41+
}, {
42+
test: [/\.js$/],
43+
exclude: /node_modules/,
44+
enforce: 'pre',
45+
loader: 'eslint-loader',
46+
options: {
47+
failOnError: true
48+
}
49+
}, {
4250
test: /\.js/,
4351
exclude: /node_modules[\/\\]proj4|classic/,
4452
loader: 'babel-loader',
@@ -51,6 +59,7 @@ module.exports = {
5159
}]
5260
},
5361
plugins: [
54-
new webpack.BannerPlugin(banner)
62+
new webpack.BannerPlugin(banner),
63+
new webpack.NoEmitOnErrorsPlugin()
5564
]
5665
};

‎build/webpack.config.openlayers.js‎

Lines changed: 12 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -24,9 +24,9 @@ module.exports = {
2424
externals: {
2525
'openlayers/dist/ol-debug': 'ol',
2626
'echarts': 'function(){try{return echarts}catch(e){return {}}}()',
27-
'mapv': "function(){try{return mapv}catch(e){return {}}}()",
27+
'mapv': "function(){try{return mapv}catch(e){return {}}}()",
2828
'elasticsearch': 'function(){try{return elasticsearch}catch(e){return {}}}()',
29-
'@turf/turf': "function(){try{return turf}catch(e){return {}}}()",
29+
'@turf/turf': "function(){try{return turf}catch(e){return {}}}()",
3030
},
3131

3232
module: {
@@ -40,6 +40,14 @@ module.exports = {
4040
limit: 30000
4141
}
4242
}]
43+
}, {
44+
test: [/\.js$/],
45+
exclude: /node_modules/,
46+
enforce: 'pre',
47+
loader: 'eslint-loader',
48+
options: {
49+
failOnError: true
50+
}
4351
}, {
4452
test: /\.js$/,
4553
exclude: /classic/,
@@ -61,6 +69,7 @@ module.exports = {
6169
},
6270
plugins: [
6371
new webpack.BannerPlugin(banner),
64-
new ExtractTextPlugin('/../dist/' + packageName + ".css")
72+
new ExtractTextPlugin('/../dist/' + packageName + ".css"),
73+
new webpack.NoEmitOnErrorsPlugin()
6574
]
6675
};

0 commit comments

Comments
 (0)