Skip to content

Use SQL parameters instead of string concatenation#426

Merged
windoze merged 1 commit intomainfrom
windoze/sql-fix
Jul 4, 2022
Merged

Use SQL parameters instead of string concatenation#426
windoze merged 1 commit intomainfrom
windoze/sql-fix

Conversation

@windoze
Copy link
Copy Markdown
Member

@windoze windoze commented Jul 2, 2022

Use SQL parameters instead of string concatenation to prevent SQL injection.

Copy link
Copy Markdown
Collaborator

@Yuqing-cat Yuqing-cat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shall I follow this practice in access control? #409

@windoze
Copy link
Copy Markdown
Member Author

windoze commented Jul 2, 2022

Shall I follow this practice in access control? #409

Yes, you should follow the practice as long as the parameters are passed from external untrusted source.

Copy link
Copy Markdown
Collaborator

@blrchen blrchen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@windoze windoze merged commit 8970c87 into main Jul 4, 2022
@xiaoyongzhu xiaoyongzhu deleted the windoze/sql-fix branch August 22, 2022 17:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants