Adding webapp and webappPlan creation to deployment ARM template #352
Merged
jainr merged 13 commits intofeathr-ai:mainfrom Jun 23, 2022
jainr:rijai/webappdeploy
Merged
Adding webapp and webappPlan creation to deployment ARM template #352jainr merged 13 commits intofeathr-ai:mainfrom jainr:rijai/webappdeploy
jainr merged 13 commits intofeathr-ai:mainfrom
jainr:rijai/webappdeploy
Conversation
…lls a public image from dockerhub. Also fixing a bug to fetch principal id
jainr
requested review from
Yuqing-cat,
blrchen,
edwincheung,
hangfei,
jaymo001,
windoze and
xiaoyongzhu
Yuqing-cat
reviewed
Jun 14, 2022
Collaborator
Yuqing-cat
left a comment
Yuqing-cat
left a comment
There was a problem hiding this comment.
Shall we have a "provisionWebApp" parameter to let user decide whether to deploy it or not just like Purview & EventHub?
Yuqing-cat
previously approved these changes
Jun 15, 2022
Member
|
title says it's still WIP so not sure it's ready to take review or not? But anyway I looked thru the changes and I'm good with those. |
blrchen
reviewed
Jun 19, 2022
Collaborator
Author
I had it work in progress, to update the final docker image that we deploy to UI app, currently it's a placeholder. |
jainr
changed the title
…and appsettings to pass it
edwincheung
approved these changes
Jun 22, 2022
Yuqing-cat
approved these changes
Jun 23, 2022
Member
|
|
Collaborator
Author
|
Thanks for the feedback @xiaoyongzhu, I will include that in subsequent PR |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://docs.microsoft.com/en-us/cli/azure/microsoft-graph-migration#breaking-changes
Successful deployment
Also adding instructions to create AAD app and to get clientId and TenantId.
Made corresponding changes in tempplate to accept them as parameters and pass it to webapp as settings.