fix(deps): add missing optional peer dependencies #259
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mairu
reviewed
Apr 11, 2024
A couple of optional peer dependencies were not declared in the package.json. This prevents compatibility with modern versions of yarn, since yarn will block access to undecalred dependencies. This adds the missing peer dependencies and marks them as optional so they only need to be installed when actually required
thiemok
force-pushed
the
fix/missing-peer-deps
branch
from
de3fc4d to
64cfcdc
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
A couple of optional peer dependencies were not declared in the package.json. This prevents compatibility with modern versions of yarn, since yarn will block access to undecalred dependencies.
This adds the missing peer dependencies and marks them as optional so they only need to be installed when actually required
I've only tested with koa. It is possible that other setups might require similar peer dependencies that I did not have problems with. However a quick look at the documentation did not mention other peer dependencies in the installation section