Skip to content

WIP: Typescript Refactor#117

Merged
fratzinger merged 4 commits into
feathersjs-ecosystem:dovefrom
fratzinger:typescript
Apr 2, 2023
Merged

WIP: Typescript Refactor#117
fratzinger merged 4 commits into
feathersjs-ecosystem:dovefrom
fratzinger:typescript

Conversation

@fratzinger

@fratzinger fratzinger commented Sep 7, 2022

Copy link
Copy Markdown
Contributor

BREAKING CHANGES included.

@DaddyWarbucks

Copy link
Copy Markdown
Collaborator

Want me to wait to merge this?

@DaddyWarbucks

Copy link
Copy Markdown
Collaborator

Sorry. Accidentally hit "Close with comment" instead of just "Comment".

@fratzinger

Copy link
Copy Markdown
Contributor Author

Definitely wait! Putting "WIP" in front of the title does not make it a draft on github?! I'll let you know, when I think it's ready.

@daffl

daffl commented Sep 7, 2022

Copy link
Copy Markdown
Member

I think you have to explicitly open it as a draft PR but you should also be able to turn it into a draft in the sidebar on the left. Anyway, sorry for jumping into the conversation, see you in two days @fratzinger (I'm in Düsseldorf now which is basically 80% of the way 😄)!

@fratzinger fratzinger marked this pull request as draft September 7, 2022 20:05
- remove 'order' & 'sku' service because of stripe v11
- move to feathers v5
- use unbuild for building
@fratzinger fratzinger changed the base branch from master to dove April 2, 2023 16:48
@fratzinger fratzinger marked this pull request as ready for review April 2, 2023 16:49
@fratzinger

Copy link
Copy Markdown
Contributor Author

I'll merge this into branch dove now and continue from there. Hopefully we will have CI then. I'll open a new PR with that branch.

@fratzinger fratzinger merged commit aa545b6 into feathersjs-ecosystem:dove Apr 2, 2023
@fratzinger fratzinger deleted the typescript branch April 2, 2023 16:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants