fix: service find method return type#427
Open
yassinedorbozgithub wants to merge 1 commit intofeathersjs-ecosystem:masterfrom
Open
fix: service find method return type#427yassinedorbozgithub wants to merge 1 commit intofeathersjs-ecosystem:masterfrom
yassinedorbozgithub wants to merge 1 commit intofeathersjs-ecosystem:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
When we use the find method of a service that extends SequelizeService<R, D, SP, PD> the return type is not like expected.
We got an union of paginated type and not paginated type
Expected behavior
By default the feathers service return a paginated response if we don't specify the field paginated: false.
So the returned type of a find method need to be paginated by default.
#426 426