Repository navigation
Optimize multi patch when $returning is false. #382
Description
I noticed this while making this comment: feathersjs/feathers#2472 (comment)
I believe we are potentially wasting some calls to _getOrFind if the user is using $returning: false. Note here:
feathers-sequelize/lib/index.js
Line 222 in db4b5ff
that we are fetching the
idList so that the modified results can be returned. But, we don't know for certain that the results need to be returned until feathers-sequelize/lib/index.js
Line 245 in db4b5ff
We should move some code around so that we are not fetching the idList until we check if params.$returning !== false. The _remove method does this. So we should update patch to work similarly.
Reacted by fratzinger
Activity
fratzinger commentedon Jan 9, 2022
don't forget about #363 and #364
fratzinger commentedon Jan 9, 2022
feathers-sequelize/lib/index.js
Line 248 in db4b5ff
Should be
return Promise.resolve(id == null ? [] : null)Same here:
feathers-sequelize/lib/index.js
Line 300 in db4b5ff
Or should
$returningonly supported formultirequests? If so, we need to handle this as well, like:feathers-sequelize/lib/index.js
Line 293 in db4b5ff
if (params.$returning !== false && id == null)DaddyWarbucks commentedon Nov 16, 2022
Maybe relevant: #405