This repository was archived by the owner on Jun 24, 2025. It is now read-only.
Feature Request: Reusing services for mutliple redux variables#53
Open
testless wants to merge 4 commits intofeathersjs-ecosystem:masterfrom
Open
Feature Request: Reusing services for mutliple redux variables#53testless wants to merge 4 commits intofeathersjs-ecosystem:masterfrom
testless wants to merge 4 commits intofeathersjs-ecosystem:masterfrom
Conversation
At the moment, is it only possible to use a service once. But there might be situations, where you want the same services being stored in different variables. At the moment, the code assume serviceName => variableName, thus providing a way of renaming the serviceName only. My proposal here is to variableName => serviceName, which would allow something like. myUser -> users currentlySelectedUser -> users myBoss -> users
Author
|
However, this will be a breaking change. |
Author
|
Ok, I thought about it a little bit and found a better non-breaking proposition. User of your library could now use |
added 2 commits
August 21, 2018 08:55
Collaborator
|
I will have to think on this. I understand the issue and would prefer a more baked-in solution. |
|
What's the verdict on this, because it seems a good solution? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
At the moment, is it only possible to use a service once.
But there might be situations, where you want the same services being stored in different variables.
At the moment, the code assume serviceName => variableName, thus providing a way of renaming the serviceName only.
My proposal here is to variableName => serviceName, which would allow something like.
myUser -> users
currentlySelectedUser -> users
myBoss -> users
No
No