Skip to content
This repository was archived by the owner on Sep 2, 2025. It is now read-only.

Add types composite id and ERROR type #95

Merged
daffl merged 2 commits into from
May 15, 2020
Merged

Add types composite id and ERROR type #95

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a6ef1c1
Add types composite id and ERROR type
daffl May 15, 2020
6d7e7da
Generic id type
daffl May 15, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions types/index.d.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,10 @@ import { Params, Paginated, Id, NullableId } from '@feathersjs/feathers';
import { AdapterService, ServiceOptions, InternalServiceMethods } from '@feathersjs/adapter-commons';
import { Model } from 'objection';

export const ERROR: symbol;

export interface ObjectionServiceOptions extends ServiceOptions {
id: any;
model: typeof Model;
idSeparator: string;
jsonSchema: any;
Expand Down
5 changes: 4 additions & 1 deletion types/index.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
import { Model } from 'objection';
import service from 'feathers-objection';
import service, { ERROR } from 'feathers-objection';

class Todo extends Model {
static get tableName() {
Expand All @@ -8,7 +8,10 @@ class Todo extends Model {
}

const myService = service({
id: [ 'id', 'name' ],
model: Todo
});

myService.Model.tableName;

typeof ERROR === 'symbol';