update '_remove' method#364
Merged
marshallswain merged 2 commits intofeathersjs-ecosystem:masterfrom Jan 8, 2020
sarkistlt:patch-1
Merged
update '_remove' method#364marshallswain merged 2 commits intofeathersjs-ecosystem:masterfrom sarkistlt:patch-1
marshallswain merged 2 commits intofeathersjs-ecosystem:masterfrom
sarkistlt:patch-1
Conversation
#365 better support for shard cluster
Member
|
@sarkistlt thanks for the PR. |
fix for failed test that uses id + query to remove record(s)
Contributor
Author
|
@marshallswain ok should be fine now |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#361
Summary
Better support for shard cluster.
Other Information
Replace
findOneAndDeletewith combination offindByIdanddeleteOne, because in the shard cluster based on MongoDB specification if you are usingfindOneAnd[*]you have to pass entire shard key, which can be a combination of different fields.This should not be required when you trying to remove document from the collection, just providing
_idshould be enough.