Add support for setting schema in hook params#255
Draft
dyllan-to-you wants to merge 2 commits intofeathersjs-ecosystem:masterfrom
Draft
Add support for setting schema in hook params#255dyllan-to-you wants to merge 2 commits intofeathersjs-ecosystem:masterfrom
schema in hook params#255dyllan-to-you wants to merge 2 commits intofeathersjs-ecosystem:masterfrom
Conversation
|
Any update on this? I want to be able to dynamically change the schema being used based on the logged in user. I see theres an option to set the schema when defining the service currently, but that doesn't work for this scenario. Adding the ability to set the schema in a hook would allow it to dynamically be changed. Is there a better currently supported way? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Tell us about the problem your pull request is solving.
Allow a user to set the schema a request will use by setting
params.schemawithin a hook. This matches the API infeathers-objectionAre there any open issues that are related to this?
No
Is this PR dependent on PRs in other repos?
No
If so, please mention them to keep the conversations linked together.
Other Information
Caveats:
fullNamegetter is inaccurate wheneverschemaparameter is used. This results in weirdness in the tests and an inaccurate debug statement. Not sure how to remedy without breaking thefullNamegetter.Outstanding Tasks: