Typescript refactoring, seperate services, custom methods and vitepress docs#164
Merged
Conversation
- complete typing - update dependencies - semistandard -> eslint-typescript - start converting tests to typescript - ref #144
- identityChange had no 'field' property - tests fixes
- add passwordField to options - propper typing
- call seperate services from main service
- destructure create-data for better IDE support - move AuthenticationManagementService to seperate file
- completely move `passwordField` to options
- Base class with publish-prevention
- `useSeparateServicePaths` option
- use internal service.options instead of create({ action: 'options' })
- add tests for publish
- add tests for `useSeparateServicePaths`
- more typings
- export defaultOptions -> addVerification - path - rearrange useSeparateServices
- divide Service & configure functions - ensure options per Service - types: better types - chore: update dependencies - tests: add tests for separate services - tests: increase about-time to 600
- better typing (abstract _create with type) - sort actions alphabetically
- overview page - started services page
move typescript refactor to repo branch
18 tasks
added 2 commits
September 11, 2021 13:49
- refactor: add import type where necessary - refactor: add newlines for function params - refactor: destructure imports
- rename user1, user2, user3 to declarative names - use $limit: 2 everywhere - use [passwordField] consequently
|
I tested verifySignupLong functionality and it works as advertised. Will check the other hooks this week. Well done. |
|
Mongoose Models need |
- feat: add 'passParams' option
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
tl;dr
Checkout the migration guide: https://feathers-a-m.netlify.app/migration.html
New Features:
actionhas a new separate service now:see #159 for the beginning of Discussion. We continue the refactoring here.
Todos:
srcto typescript is pretty much done with typesclientis backward compatibletestto typescriptaction_createfor every service to make it possible to skip hooks as foradapter-commonsservice.publishdoes not get hit to prevent channel emitapp.use)New Stuff:
passwordFieldfor dynamic passwordField. It was a fixed variable before_createfunction on all services to bypass hooksaction: 'options')app.service('authManagement')._resetPasswordLong(...))app.service('authManagement').resetPasswordLong(...)app.use('auth-management, new AuthenticationManagementService(app, { ... })instead ofapp.configure(authManagement)Todo:
IDE-Support:
closes #144, #138