Draft: typescript refactoring#159
Conversation
- complete typing - update dependencies - semistandard -> eslint-typescript - start converting tests to typescript - ref #144
- identityChange had no 'field' property - tests fixes
- add passwordField to options - propper typing
- call seperate services from main service
- destructure create-data for better IDE support - move AuthenticationManagementService to seperate file
|
Thank you for putting this up! I sent you an invite to the repository so you can work with it more directly. I'll be happy to give some pointers on repository organization but will leave review up to the other maintainers. One thing to maybe consider since it is already a refactoring would be how the API could be improved working with the upcoming more custom methods feathersjs/feathers#1976 |
|
Thanks for your trust. I happily accepted the invite. I will speak up, when I got something new. |
- completely move `passwordField` to options
|
This is awesome, thanks for the work ! |
|
Thanks :) I'm not quite through though. Currently I have not that much time, but I'm willing to get this finished. |
- Base class with publish-prevention
- `useSeparateServicePaths` option
- use internal service.options instead of create({ action: 'options' })
- add tests for publish
- add tests for `useSeparateServicePaths`
- more typings
|
I think this is getting somewhere and I want to open a discussion on some thoughts, that I have:
@claustres @TheSinding What do you think about the two points above? And what do you think about this PR at all? Any pointers, criticism, etc. is highly appreciated! Are there points, that disturbed you in Any comments are appreciated :) |
|
Hi @fratzinger, this is huge, thanks a lot! Just to clarify what you did: this is not only a port to TypeScript, but you are also going to implement the "REST wrapper" discussed in #144, right? Is this what you mean with "separate services"? And will this new version of the package be fully backward compatible? |
|
- export defaultOptions -> addVerification - path - rearrange useSeparateServices
- divide Service & configure functions - ensure options per Service - types: better types - chore: update dependencies - tests: add tests for separate services - tests: increase about-time to 600
- better typing (abstract _create with type) - sort actions alphabetically
- overview page - started services page
|
closed in favor of #164 . See ongoing work over there. |
This is a port to typescript, as it was discussed here before. It seems that the solution from @MohammedFaragallah is not actively maintained. So hopefully we can work out a typescript-version, which gets merged.
Todos:
srcto typescript is pretty much done with typesclientis backward compatibletestto typescriptaction_createfor every service to make it possible to skip hooks as foradapter-commonsservice.publishdoes not get hit to prevent channel emitapp.use)New Stuff:
passwordFieldfor dynamic passwordField. It was a fix variable before_createfunction on all services to bypass hooksaction: 'options')IDE-Support: