Skip to content

fix: MaybeArray with readonly array #24

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
fratzinger merged 1 commit into from
Mar 6, 2026
Merged

fix: MaybeArray with readonly array #24

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 22 additions & 0 deletions src/hooks/params-for-server/params-for-server.hook.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,28 @@ describe('paramsForServer', () => {
})
})

it('should accept a readonly array', () => {
const whitelist = ['a', 'b'] as const
expect(
paramsForServer(whitelist)({
params: {
a: 1,
b: 2,
query: {},
},
} as HookContext),
).toEqual({
params: {
query: {
_$client: {
a: 1,
b: 2,
},
},
},
})
})

it('should move params to query._$client and leave remaining', () => {
expect(
paramsForServer('a')({
Expand Down
6 changes: 3 additions & 3 deletions src/internal.utils.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,9 +7,9 @@ export const hasOwnProperty = (
return keys.some((x) => Object.prototype.hasOwnProperty.call(obj, x))
}

export type MaybeArray<T> = T | T[]
export const toArray = <T>(value: T | T[]): T[] =>
Array.isArray(value) ? value : [value]
export type MaybeArray<T> = T | readonly T[]
export const toArray = <T>(value: T | readonly T[]): T[] =>
Array.isArray(value) ? [...value] : [value as T]

export type Promisable<T> = T | Promise<T>
export type KeyOf<T> = Extract<keyof T, string>
Expand Down
Loading