Aligning TypeScript configuration and improving type exports#125
Open
sajov wants to merge 6 commits intofeathersjs:mainfrom
Open
Aligning TypeScript configuration and improving type exports#125sajov wants to merge 6 commits intofeathersjs:mainfrom
sajov wants to merge 6 commits intofeathersjs:mainfrom
Conversation
Removed 'type' field from package.json
Removed re-export of Elasticsearch types to reduce redundancy.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This pull request modernizes the Elasticsearch adapter by aligning TypeScript configuration and improving type exports.
It includes:
🔧 Configuration cleanup
• Removed the "type" field from package.json to avoid forcing ESM.
• Adjusted TypeScript compilation settings (target and module) for better compatibility with current build targets.
• Removed moduleResolution from tsconfig, allowing the project to inherit standard resolution defaults.
📦 Type improvements
• Removed redundant re-exports of Elasticsearch types, reducing duplication and potential confusion.
• Added explicit Elasticsearch type definitions to src/types.ts to provide stronger typing for consumers.
• Exported additional helper types from src/types.ts to improve the DX for TypeScript users.
These changes are non-breaking for existing JavaScript/TypeScript users and improve overall type safety and compatibility with modern TypeScript setups.
⸻
✅ Motivation
The goals of this PR are to:
• Align the adapter with more predictable TypeScript configuration defaults.
• Make Elasticsearch types more explicit and easier to consume.
• Reduce unnecessary re-exports that add maintenance burden.
⸻
🧪 Tests & Documentation
If no tests or documentation updates are included, you can add a note here (optional), e.g. “No functional changes were made so tests were not added or modified.”
⸻
📌 Notes for Maintainers
• This PR only affects developer/consumer build/typing experience; runtime behavior is unchanged.
• If you’d prefer these changes split into smaller reviewable commits, I can rebase accordingly.
⸻