Skip to content

Aligning TypeScript configuration and improving type exports#125

Open
sajov wants to merge 6 commits intofeathersjs:mainfrom
sajov:main
Open

Aligning TypeScript configuration and improving type exports#125
sajov wants to merge 6 commits intofeathersjs:mainfrom
sajov:main

Conversation

@sajov
Copy link
Copy Markdown

@sajov sajov commented Feb 19, 2026

Summary

This pull request modernizes the Elasticsearch adapter by aligning TypeScript configuration and improving type exports.

It includes:

🔧 Configuration cleanup
• Removed the "type" field from package.json to avoid forcing ESM.
• Adjusted TypeScript compilation settings (target and module) for better compatibility with current build targets.
• Removed moduleResolution from tsconfig, allowing the project to inherit standard resolution defaults.

📦 Type improvements
• Removed redundant re-exports of Elasticsearch types, reducing duplication and potential confusion.
• Added explicit Elasticsearch type definitions to src/types.ts to provide stronger typing for consumers.
• Exported additional helper types from src/types.ts to improve the DX for TypeScript users.

These changes are non-breaking for existing JavaScript/TypeScript users and improve overall type safety and compatibility with modern TypeScript setups.

✅ Motivation

The goals of this PR are to:
• Align the adapter with more predictable TypeScript configuration defaults.
• Make Elasticsearch types more explicit and easier to consume.
• Reduce unnecessary re-exports that add maintenance burden.

🧪 Tests & Documentation

If no tests or documentation updates are included, you can add a note here (optional), e.g. “No functional changes were made so tests were not added or modified.”

📌 Notes for Maintainers
• This PR only affects developer/consumer build/typing experience; runtime behavior is unchanged.
• If you’d prefer these changes split into smaller reviewable commits, I can rebase accordingly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant