Throw an error when registering a service after application start - #78
Merged
Merged
Conversation
daffl
added a commit
that referenced
this pull request
Jun 11, 2014
Throw an error when registering a service after application start
Closed
daffl
added a commit
that referenced
this pull request
Aug 19, 2018
daffl
added a commit
that referenced
this pull request
Aug 21, 2018
daffl
pushed a commit
that referenced
this pull request
Aug 21, 2018
daffl
pushed a commit
that referenced
this pull request
Aug 22, 2018
daffl
pushed a commit
that referenced
this pull request
Aug 24, 2018
daffl
added a commit
that referenced
this pull request
Aug 29, 2018
daffl
added a commit
that referenced
this pull request
Aug 29, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As discussed in and closes #67, Feathers now throws an error when trying to register a service after
app.setup()has already been called since some providers (SocketIO) might need all services registered when starting the application.