Updated to handle array emit for service results. - #743
Merged
Merged
Conversation
Added tests to simulate the array results, and promises that check the results are correct.
Contributor
Author
|
resolves #740 |
Member
|
Thank you for doing this! Haven't heard back from Codeclimate so just merged and will see if it can be fixed once I hear back. Released as v3.0.2 |
This was referenced Dec 12, 2017
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixed emit to use Array.isArray and emit multiples for array results.
Updated tests with array values to ensure the emits were handled properly.
Refactored the tests to bring the value below the testing limit of 5