Skip to content

No longer pollutes the global scope - #662

Merged
daffl merged 3 commits into
feathersjs:masterfrom
bertho-zero:master
Sep 1, 2017
Merged

No longer pollutes the global scope#662
daffl merged 3 commits into
feathersjs:masterfrom
bertho-zero:master

Conversation

@bertho-zero

@bertho-zero bertho-zero commented Aug 31, 2017

Copy link
Copy Markdown
Contributor

No description provided.

@bertho-zero

bertho-zero commented Aug 31, 2017 •
edited
Loading

Copy link
Copy Markdown
Contributor Author

Fix this error:

TypeError: Cannot redefine property: Symbol(Symbol.iterator)
    at Object.defineProperty [as f] (<anonymous>)
    at module.exports.object.(anonymous function) (/home/bertho/dev/X/node_modules/core-js/modules/_hide.js:4:13)
    at module.exports (/home/bertho/dev/X/node_modules/core-js/modules/_iter-define.js:54:5)
    at Object.<anonymous> (/home/bertho/dev/X/node_modules/core-js/modules/es6.array.iterator.js:11:43)
    at Module._compile (module.js:569:30)
    at Object.Module._extensions..js (module.js:580:10)
    at Module.load (module.js:503:32)
    at tryModuleLoad (module.js:466:12)
    at Function.Module._load (module.js:458:3)
    at Module.require (module.js:513:17)
    at require (internal/module.js:11:18)
    at Object.<anonymous> (/home/bertho/dev/X/node_modules/core-js/shim.js:100:1)
    at Module._compile (module.js:569:30)
    at Object.Module._extensions..js (module.js:580:10)
    at Module.load (module.js:503:32)
    at tryModuleLoad (module.js:466:12)
    at Function.Module._load (module.js:458:3)
    at Module.require (module.js:513:17)
    at require (internal/module.js:11:18)
    at Object.<anonymous> (/home/bertho/dev/X/node_modules/babel-polyfill/lib/index.js:3:1)
    at Module._compile (module.js:569:30)
    at Object.Module._extensions..js (module.js:580:10)
    at Module.load (module.js:503:32)
    at tryModuleLoad (module.js:466:12)
    at Function.Module._load (module.js:458:3)
    at Module.require (module.js:513:17)
    at require (internal/module.js:11:18)
    at Object.<anonymous> (/home/bertho/dev/X/node_modules/feathers/lib/index.js:19:3)
    at Module._compile (module.js:569:30)
    at Object.Module._extensions..js (module.js:580:10)
    at Module.load (module.js:503:32)
    at tryModuleLoad (module.js:466:12)
    at Function.Module._load (module.js:458:3)
    at Module.require (module.js:513:17)
    at require (internal/module.js:11:18)
    at Object.<anonymous> (/home/bertho/dev/X/api/index.js:5:18)

caused by:

// global._babelPolyfill = true; // work with this line
const feathers = require( 'feathers' );

@daffl
daffl merged commit 7422757 into feathersjs:master Sep 1, 2017
@daffl

daffl commented Sep 1, 2017

Copy link
Copy Markdown
Member

Thank you @bertho-zero this is great! Although this is also already fixed in the next version it totally makes sense to release this as a minor version 2.2.0

@daffl daffl mentioned this pull request Sep 1, 2017
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@bertho-zero @daffl