Skip to content

Added patch support#47

Merged
daffl merged 3 commits into
feathersjs:masterfrom
mlaug:master
Apr 1, 2014
Merged

Added patch support#47
daffl merged 3 commits into
feathersjs:masterfrom
mlaug:master

Conversation

@mlaug

@mlaug mlaug commented Mar 28, 2014

Copy link
Copy Markdown
Contributor

No description provided.

@mlaug mlaug changed the title added patch support added patch support (in combination with legs https://github.com/feathersjs/legs/pull/7) Mar 28, 2014
@mlaug mlaug changed the title added patch support (in combination with legs https://github.com/feathersjs/legs/pull/7) added patch support (in combination with legs) Mar 28, 2014
@mlaug

mlaug commented Mar 28, 2014

Copy link
Copy Markdown
Contributor Author

the pull request I stated for legs to make use of this PATCH request https://github.com/feathersjs/legs/pull/7

@daffl daffl added this to the 0.4.0 milestone Mar 28, 2014
@daffl

daffl commented Mar 28, 2014

Copy link
Copy Markdown
Member

Yes! This makes total sense. I actually kept running into this myself. Although patch is the name of the HTTP verb, I think it is descriptive enough to keep it as a service method name (unless there are other ideas).

@daffl

daffl commented Mar 28, 2014

Copy link
Copy Markdown
Member

/cc @Glavin001 @ekryski

@Glavin001

Copy link
Copy Markdown
Contributor

👍 Code looks good. Would you be able to add a test for this, @mlaug, to test/provides/rest.test.js? Then I am all for merging this. Thanks!

@mlaug

mlaug commented Mar 29, 2014

Copy link
Copy Markdown
Contributor Author

sure, as for the other pull request will create a test right after the weekend

@daffl

daffl commented Mar 29, 2014

Copy link
Copy Markdown
Member

We should probably test this with SocketIO and Primus as well. The best way is probably adding the patch to https://github.com/feathersjs/feathers/blob/master/test/providers/service-fixture.js. We also shouldn't forget to document it and add it to the examples.

@Glavin001

Copy link
Copy Markdown
Contributor

Great, thanks @mlaug.

Good points, @daffl. More things to do before releasing this additional feature.

@ekryski

ekryski commented Mar 29, 2014

Copy link
Copy Markdown
Contributor

Looks good. Thanks @mlaug.

@mlaug

mlaug commented Apr 1, 2014

Copy link
Copy Markdown
Contributor Author

I have added testcases for the patch support, hope that suits it

@ekryski

ekryski commented Apr 1, 2014

Copy link
Copy Markdown
Contributor

I've been a bit out of the loop lately but this looks good to me! @daffl or @Glavin001 I'll let you guys pull the trigger.

@daffl daffl changed the title added patch support (in combination with legs) added patch support Apr 1, 2014
@daffl daffl changed the title added patch support Added patch support Apr 1, 2014
@daffl

daffl commented Apr 1, 2014

Copy link
Copy Markdown
Member

Nice! Thanks again! I'll add some docs in the readme as well.

daffl added a commit that referenced this pull request Apr 1, 2014
@daffl
daffl merged commit 7b94b75 into feathersjs:master Apr 1, 2014
@Glavin001

Copy link
Copy Markdown
Contributor

👍 Thank you, @mlaug!

daffl added a commit that referenced this pull request Aug 21, 2018
daffl pushed a commit that referenced this pull request Aug 21, 2018
* chore(package): update dependencies

https://greenkeeper.io/

* docs(readme): add Greenkeeper badge

https://greenkeeper.io/
daffl added a commit that referenced this pull request Aug 22, 2018
daffl pushed a commit that referenced this pull request Aug 22, 2018
* chore(package): update dependencies

https://greenkeeper.io/

* docs(readme): add Greenkeeper badge

https://greenkeeper.io/
daffl pushed a commit that referenced this pull request Aug 29, 2018
daffl pushed a commit that referenced this pull request Aug 29, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants