adding .github folder and templates - #442
Conversation
| (First please check that this issue is not already solved as [described | ||
| here](https://github.com/feathersjs/feathers/blob/master/.github/contributing.md#report-a-bug)) | ||
|
|
||
| - [ ] Tell us how you broke things. The more detailed the better. |
There was a problem hiding this comment.
Maybe less accusing? Something like "Tell us what broke."
There was a problem hiding this comment.
Why did you break things?!!!
|
|
||
| **NodeJS version**: | ||
|
|
||
| **Operating System**: No newline at end of file |
There was a problem hiding this comment.
Should we ask for the client configuration here, too? Browser version and module loader (if applicable)
There was a problem hiding this comment.
Ya probably. At least browser version and module loader
There was a problem hiding this comment.
Very good call, the more detail the better.
|
Once we agree on this I can sort the script to add it to all repos, have a good idea on that, should be pretty simple using something like https://github.com/github/hub since I already have all the repos in a folder. |
|
@corymsmith That was my thinking as well. The quick and dirty would be if you already have the folders and write access to simply make a script that rips through all of them and copies the folder to each one, adds it to the end of |
|
Exactly what I was thinking, though I was thinking of PR but thats probably overkill |
|
For this stuff I think so. It doesn't have any impact on code and it's going to be the same in every repo. |
|
I've got a script sorted for this so let me know when we're good to go |
… folder support. (#442) * Windows compatible version of the original compile comand with public folder support. - Was `"rm -rf lib/ && babel -d lib/ src/ && mkdir lib/public/ && cp src/public/* lib/public/"` in legacy but that wasn't windows compatible. Although `rimraf` takes care of the first half, I suspect the public copy was lost because a recursive mkdir+cp is hard to find. But `babel -D` handles that. - Also fixed the extra `-rf` that should not be used with `rimraf`. * .gitignore adds for .idea (e.g. WebStorm) and .vs (VS2017) folders * Oops, src/public only exists in the legacy branch
… folder support. (#442) * Windows compatible version of the original compile comand with public folder support. - Was `"rm -rf lib/ && babel -d lib/ src/ && mkdir lib/public/ && cp src/public/* lib/public/"` in legacy but that wasn't windows compatible. Although `rimraf` takes care of the first half, I suspect the public copy was lost because a recursive mkdir+cp is hard to find. But `babel -D` handles that. - Also fixed the extra `-rf` that should not be used with `rimraf`. * .gitignore adds for .idea (e.g. WebStorm) and .vs (VS2017) folders * Oops, src/public only exists in the legacy branch
3 participants
@feathersjs/core-team please review and add feedback. We'll iterate in this PR and then can add a script to add this folder to all the other repos as outlined in #435.