Repository navigation
fix(socketio): attach to a server built on uWebSockets.js - #3731
Open
nigrosimone wants to merge 1 commit into
Open
nigrosimone wants to merge 1 commit into
nigrosimone wants to merge 1 commit into
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Some Express compatible servers are built on uWebSockets.js and expose the uWS app as
uwsApp, for example ultimate-express and fulmine.js. Withexpress(feathers(), ultimateExpress())REST works, butsetup(server)doesnew Server(server)and socket.io can not attach, so the websocket connection fails.Now when the server has
uwsApp(and no port is given), socket.io is created without a server and attached withio.attachApp(server.uwsApp). Other servers are unchanged.Test:
app.setup()with a callable server carrying a stubuwsApp, socket.io registers its routes on it. It fails without the fix. I also ran a Feathers app with REST, socket calls and the realtime event on Express, ultimate-express and fulmine.js, the output is the same.