Repository navigation
fix(schema): recheck external dispatch after resolving - #3705
Merged
Merged
Conversation
daffl
approved these changes
Sep 24, 2026
Member
|
This looks good, thank you for getting that in! It will go out with the next release! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
resolveExternalcan encounter dispatch data created by a nested service call or a concurrent resolver after its initial cache check. Defining the same non-configurable dispatch property again then throwsCannot redefine property.Check the cache again immediately before each item-level and result-level write, reusing dispatch data already produced while awaiting resolution. This covers repeated result objects and concurrent calls sharing the same array or paginated container.
Other Information
Added five service-level regressions, all failing with the reported TypeError on the original code. Tests also verify that filtered dispatch data is reused while the original service data remains intact.
npm test --workspace=@feathersjs/schemapasses all 42 tests, including compilation and package checks. TypeScript, ESLint, Prettier, and diff checks pass for this change.