Skip to content

chore(ci): align workflow Node.js version with package engines - #3694

Merged
daffl merged 2 commits into
feathersjs:dovefrom
MGPOCKY:fix/ci-node-version-mismatch
Sep 11, 2026
Merged

daffl merged 2 commits into
feathersjs:dovefrom
MGPOCKY:fix/ci-node-version-mismatch

Conversation

@MGPOCKY

@MGPOCKY MGPOCKY commented Jul 31, 2026

Copy link
Copy Markdown
Contributor

Why

Package metadata declares engines.node / volta.node / .nvmrc as 20,22,24,26, but CI workflows still pin node-version to a mismatched value.

That can make CI run on a runtime the project no longer supports (or skip the version the package actually targets).

What changed

Update the affected workflow node-version pins so they satisfy 20,22,24,26 (using 26 where a concrete pin is needed).

  • .github/workflows/update-dependencies.yml
    • node-version: '18.x'node-version: '20.x'

Test plan

  • Package engines.node / volta.node / .nvmrc is still 20,22,24,26
  • Updated workflows now use versions consistent with that constraint
  • Relevant CI jobs on this branch look healthy

Found while auditing CI/package version consistency across popular repos.

@MGPOCKY
MGPOCKY marked this pull request as ready for review July 31, 2026 09:17

@daffl daffl left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This makes sense. Changed the version to 24.x since it should still work.

@daffl daffl changed the title fix(ci): align workflow Node.js version with package engines chore(ci): align workflow Node.js version with package engines Sep 11, 2026
@daffl
daffl merged commit 8a658eb into feathersjs:dove Sep 11, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants