You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This will be a breaking change because of the changes in TypeBox Type.Intersect and Type.Composite and the removal of $in and $nin support for querying arrays in MongoDb which broke the TypeScript type inference mechanism.
@daffl FYI - typebox 1.0 was just released. Notably, Type.Composite was removed (which this PR just moved to). Now that it's 1.0, I expect future releases will be less likely to include breaking changes. There are also some specific changes feathers might be interested to support different library and user versions of typebox (by moving off of symbols and onto ~ prefixed properties)
I thought there wouldn't be yet another change around this in the final version. Follow up PR is in #3616 but even just trying to compile the package completely crashes the TypeScript compiler for me.
That's unfortunate. Hopefully typebox's API is stabilized now. It would be really great to kick off feathers v6 with 1 of typebox, but I definitely feel your pain (and appreciate all the effort you've put into feathers over the years!).
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This will be a breaking change because of the changes in TypeBox
Type.IntersectandType.Compositeand the removal of$inand$ninsupport for querying arrays in MongoDb which broke the TypeScript type inference mechanism.