-
-
Notifications
You must be signed in to change notification settings - Fork 793
feat: SSE real-time events #3601
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
+1,168
−647
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Deploying feathers-dove with
|
| Latest commit: |
356555d
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://2a8672e1.feathers.pages.dev |
| Branch Preview URL: | https://v6-sse.feathers.pages.dev |
Member
marshallswain
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Issue: Library shouldn't log directly to console
Current:
try {
client.service(payload.path).emit(payload.event, payload.data)
} catch (error) {
console.error(error) // ❌ Library shouldn't log directly
}
Suggested:
try {
client.service(payload.path).emit(payload.event, payload.data)
} catch (error) {
sseService.emit('error', error) // ✅ Let the app decide what to do
}
Why this matters:
1. Library best practice - Applications should control their own logging/error
reporting
2. Event processing errors - This catches errors in user event handlers that apps may
want to handle differently
3. Consistency - SSE client already emits 'connected' and 'disconnected' events
Unlike internal parsing errors (which can be silently handled), this error occurs when
processing user events - something the application should be aware of and potentially
handle (invalid service paths, malformed payload data, user handler exceptions, etc.).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With the web standard implementation of the HTTP transport and the JS generator support for service methods we can add a service that provides an endpoint for streaming service events as server sent events (SSE).
Closes #369