-
-
Notifications
You must be signed in to change notification settings - Fork 795
Add app.setup() to support HTTPS #33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
daffl
pushed a commit
that referenced
this pull request
Aug 19, 2018
daffl
pushed a commit
that referenced
this pull request
Aug 21, 2018
daffl
pushed a commit
that referenced
this pull request
Aug 21, 2018
Created a Code Climate config with ESLint and Duplication enabled. Also, enabling PR integration.
daffl
pushed a commit
that referenced
this pull request
Aug 21, 2018
daffl
pushed a commit
that referenced
this pull request
Aug 22, 2018
Created a Code Climate config with ESLint and Duplication enabled. Also, enabling PR integration.
daffl
pushed a commit
that referenced
this pull request
Aug 22, 2018
daffl
pushed a commit
that referenced
this pull request
Aug 25, 2018
daffl
added a commit
that referenced
this pull request
Aug 28, 2018
daffl
added a commit
that referenced
this pull request
Aug 28, 2018
daffl
pushed a commit
that referenced
this pull request
Aug 28, 2018
* chore(package): update jsonwebtoken to version 8.0.0 * Add babel-polyfill to tests for Node 4
daffl
pushed a commit
that referenced
this pull request
Aug 29, 2018
daffl
added a commit
that referenced
this pull request
Aug 29, 2018
daffl
added a commit
that referenced
this pull request
Aug 29, 2018
daffl
pushed a commit
that referenced
this pull request
Aug 29, 2018
* chore(package): update jsonwebtoken to version 8.0.0 * Add babel-polyfill to tests for Node 4
daffl
pushed a commit
that referenced
this pull request
Aug 29, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request adds an
app.setup(server)method to allow setting up a Feathers application with a different server than the on used inapp.listen. This closes #25 and allows to easily use HTTPS servers and virtual hosts for both, SocketIO and REST, as added to the documentation:HTTPS
With your Feathers application initialized it is easy to set up an HTTPS REST and SocketIO server:
Virtual Hosts
You can use
feathers.vhost(which is the same as Express and Connect .vhost) to run your Feathers app on a virtual host:Also adds an
app.service(path, service)convenience method as suggested by @whitecolor in #22 (app.use(path, service)will still work).